From ca0292aad9009d422c855478a700717572578432 Mon Sep 17 00:00:00 2001
From: Cayo Puigdefabregas <cayo@puigdefabregas.eu>
Date: Wed, 30 Oct 2024 16:00:23 +0100
Subject: [PATCH] fix some bugs

---
 device/templates/details.html | 6 +-----
 device/views.py               | 4 ++++
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/device/templates/details.html b/device/templates/details.html
index a4a95f5..8477948 100644
--- a/device/templates/details.html
+++ b/device/templates/details.html
@@ -30,7 +30,7 @@
           <a href="#evidences" class="nav-link" data-bs-toggle="tab" data-bs-target="#evidences">{% trans 'Evidences' %}</a>
         </li>
         <li class="nav-item">
-          <a class="nav-link" href="{% url 'device:device_web' object.id %}">Web</a>
+          <a class="nav-link" href="{% url 'device:device_web' object.id %}" target="_blank">Web</a>
         </li>
       </ul>
     </div>
@@ -53,10 +53,6 @@
         </div>
       {% endif %}
 
-      <div class="row mb-3">
-        <div class="col-lg-3 col-md-4 label">Phid</div>
-        <div class="col-lg-9 col-md-8">{{ object.id }}</div>
-      </div>
       <div class="row mb-3">
         <div class="col-lg-3 col-md-4 label">Type</div>
         <div class="col-lg-9 col-md-8">{{ object.type }}</div>
diff --git a/device/views.py b/device/views.py
index eda5249..90b43e8 100644
--- a/device/views.py
+++ b/device/views.py
@@ -117,6 +117,10 @@ class PublicDeviceWebView(TemplateView):
     def get(self, request, *args, **kwargs):
         self.pk = kwargs['pk']
         self.object = Device(id=self.pk)
+        
+        if not self.object.last_evidence:
+            raise Http404
+        
         if self.request.headers.get('Accept') == 'application/json':
             return self.get_json_response()
         return super().get(request, *args, **kwargs)