device/models.py

@@ -129,8 +129,7 @@ class Device:
         return self.uuids[0]
 
     def get_lots(self):
-        self.lots = [
-            x.lot for x in DeviceLot.objects.filter(device_id=self.id)]
+        self.lots = [x.lot for x in DeviceLot.objects.filter(device_id=self.id)]
 
     @classmethod
     def get_unassigned(cls, institution, offset=0, limit=None):
@@ -180,6 +179,7 @@ class Device:
         count = cls.get_unassigned_count(institution)
         return devices, count
 
+
     @classmethod
     def get_unassigned_count(cls, institution):
 
@@ -279,12 +279,6 @@ class Device:
             self.get_last_evidence()
         return self.last_evidence.get_manufacturer()
 
-    @property
-    def serial_number(self):
-        if not self.last_evidence:
-            self.get_last_evidence()
-        return self.last_evidence.get_serial_number()
-
     @property
     def type(self):
         if self.last_evidence.doc['type'] == "WebSnapshot":

device/templates/details.html

@@ -84,7 +84,7 @@
           <div class="col-lg-3 col-md-4 label">
             {% trans 'Serial Number' %}
           </div>
-          <div class="col-lg-9 col-md-8">{{ object.serial_number|default:'' }}</div>
+          <div class="col-lg-9 col-md-8">{{ object.last_evidence.doc.device.serialNumber|default:'' }}</div>
         </div>
       {% endif %}
 

device/templates/device_web.html

@@ -120,13 +120,11 @@
               <div class="col-md-4 info-label">Model</div>
               <div class="col-md-8 info-value">{{ object.model|default:'' }}</div>
             </div>
-            {% if user.is_authenticated %}
             <div class="info-row row">
               <div class="col-md-4 info-label">Serial Number</div>
-                <div class="col-md-8 info-value">{{ object.serial_number|default:'' }}</div>
+              <div class="col-md-8 info-value">{{ object.last_evidence.doc.device.serialNumber|default:'' }}</div>
             </div>
           {% endif %}
-          {% endif %}
         </div>
 
         <div class="col-lg-6">
@@ -138,6 +136,7 @@
           {% endfor %}
         </div>
       </div>
+
       <h2 class="section-title mt-5">Components</h2>
       <div class="row">
         {% for component in object.components %}
@@ -148,10 +147,8 @@
                 <p class="card-text">
                   {% for component_key, component_value in component.items %}
                     {% if component_key not in 'actions,type' %}
-                      {% if component_key != 'serialNumber' or user.is_authenticated %}
                       <strong>{{ component_key }}:</strong> {{ component_value }}<br />
                     {% endif %}
-                    {% endif %}
                   {% endfor %}
                 </p>
               </div>
@@ -160,6 +157,7 @@
         {% endfor %}
       </div>
     </div>
+
     <footer>
       <p>
         &copy;{% now 'Y' %} eReuse. All rights reserved.

device/tests/test_mock_device.py

@@ -3,14 +3,30 @@ from unittest.mock import MagicMock
 
 
 class TestDevice(Device):
-    def __init__(self, id):
-        super().__init__(id=id)
-        self.shortid = id[:6].upper()
-        self.uuids = []
-        self.hids = ['hid1', 'hid2']
-        self._setup_evidence()
+    """A test subclass of Device that overrides the database-dependent methods"""
+    # TODO Leaving commented bc not used, but might be useful at some  point
+    # def get_annotations(self):
+    #     """Return empty list instead of querying database"""
+    #     return []
 
-    def _setup_evidence(self):
+    # def get_uuids(self):
+    #     """Set uuids directly instead of querying"""
+    #     self.uuids = ['uuid1', 'uuid2']
+
+    # def get_hids(self):
+    #     """Set hids directly instead of querying"""
+    #     self.hids = ['hid1', 'hid2']
+
+    # def get_evidences(self):
+    #     """Set evidences directly instead of querying"""
+    #     self.evidences = []
+
+    # def get_lots(self):
+    #     """Set lots directly instead of querying"""
+    #     self.lots = []
+
+    def get_last_evidence(self):
+        if not hasattr(self, '_evidence'):
             self._evidence = MagicMock()
             self._evidence.doc = {
                 'type': 'Computer',
@@ -28,22 +44,33 @@ class TestDevice(Device):
                 {
                     'type': 'CPU',
                     'model': 'Intel i7',
-                'manufacturer': 'Intel',
-                'serialNumber': 'SN12345678'
+                    'manufacturer': 'Intel'
                 },
                 {
                     'type': 'RAM',
                     'size': '8GB',
-                'manufacturer': 'Kingston',
-                'serialNumber': 'SN87654321'
+                    'manufacturer': 'Kingston'
                 }
             ]
         self.last_evidence = self._evidence
 
-    @property
-    def components(self):
-        return self.last_evidence.get_components()
 
-    @property
-    def serial_number(self):
-        return self.last_evidence.doc['device']['serialNumber']
+class TestWebSnapshotDevice(TestDevice):
+    """A test subclass of Device that simulates a WebSnapshot device"""
+
+    def get_last_evidence(self):
+        if not hasattr(self, '_evidence'):
+            self._evidence = MagicMock()
+            self._evidence.doc = {
+                'type': 'WebSnapshot',
+                'kv': {
+                    'URL': 'http://example.com',
+                    'Title': 'Test Page',
+                    'Timestamp': '2024-01-01'
+                },
+                'device': {
+                    'type': 'Laptop'
+                }
+            }
+        self.last_evidence = self._evidence
+        return self._evidence

device/tests/test_public_device_web.py

@@ -2,8 +2,7 @@ from django.test import TestCase, Client
 from django.urls import reverse
 from unittest.mock import patch
 from device.views import PublicDeviceWebView
-from device.tests.test_mock_device import TestDevice
-from user.models import User, Institution
+from device.tests.test_mock_device import TestDevice, TestWebSnapshotDevice
 
 
 class PublicDeviceWebViewTests(TestCase):
@@ -12,99 +11,57 @@ class PublicDeviceWebViewTests(TestCase):
         self.test_id = "test123"
         self.test_url = reverse('device:device_web',
                                 kwargs={'pk': self.test_id})
-        self.institution = Institution.objects.create(
-            name="Test Institution"
-        )
-        self.user = User.objects.create_user(
-            email='test@example.com',
-            institution=self.institution,
-            password='testpass123'
-        )
 
     def test_url_resolves_correctly(self):
+        """Test that the URL is constructed correctly"""
         url = reverse('device:device_web', kwargs={'pk': self.test_id})
         self.assertEqual(url, f'/device/{self.test_id}/public/')
 
     @patch('device.views.Device')
-    def test_html_response_anonymous(self, MockDevice):
+    def test_html_response(self, MockDevice):
         test_device = TestDevice(id=self.test_id)
         MockDevice.return_value = test_device
         response = self.client.get(self.test_url)
-        self.assertEqual(response.status_code, 200)
-        self.assertTemplateUsed(response, 'device_web.html')
-        self.assertContains(response, 'Test Manufacturer')
-        self.assertContains(response, 'Test Model')
-        self.assertContains(response, 'Computer')
-        self.assertContains(response, self.test_id)
-        self.assertNotContains(response, 'Serial Number')
-        self.assertNotContains(response, 'serialNumber')
 
-    @patch('device.views.Device')
-    def test_html_response_authenticated(self, MockDevice):
-        test_device = TestDevice(id=self.test_id)
-        MockDevice.return_value = test_device
-        self.client.login(username='test@example.com', password='testpass123')
-        response = self.client.get(self.test_url)
         self.assertEqual(response.status_code, 200)
         self.assertTemplateUsed(response, 'device_web.html')
+
         self.assertContains(response, 'Test Manufacturer')
         self.assertContains(response, 'Test Model')
         self.assertContains(response, 'Computer')
         self.assertContains(response, self.test_id)
-        self.assertContains(response, 'Serial Number')
-        self.assertContains(response, 'Components')
+
         self.assertContains(response, 'CPU')
         self.assertContains(response, 'Intel')
         self.assertContains(response, 'RAM')
         self.assertContains(response, 'Kingston')
 
     @patch('device.views.Device')
-    def test_json_response_anonymous(self, MockDevice):
+    def test_json_response(self, MockDevice):
         test_device = TestDevice(id=self.test_id)
         MockDevice.return_value = test_device
+
         response = self.client.get(
             self.test_url,
             HTTP_ACCEPT='application/json'
         )
+
         self.assertEqual(response.status_code, 200)
         self.assertEqual(response['Content-Type'], 'application/json')
+
         json_data = response.json()
         self.assertEqual(json_data['id'], self.test_id)
         self.assertEqual(json_data['shortid'], self.test_id[:6].upper())
-        self.assertEqual(json_data['uuids'], [])
-        self.assertEqual(json_data['hids'], ['hid1', 'hid2'])
-        self.assertNotIn('serial_number', json_data)
-        self.assertNotIn('serialNumber', json_data)
+        self.assertEqual(json_data['components'], test_device.components)
 
     @patch('device.views.Device')
-    def test_json_response_authenticated(self, MockDevice):
-        test_device = TestDevice(id=self.test_id)
+    def test_websnapshot_device(self, MockDevice):
+        test_device = TestWebSnapshotDevice(id=self.test_id)
         MockDevice.return_value = test_device
-        self.client.login(username='test@example.com', password='testpass123')
-        response = self.client.get(
-            self.test_url,
-            HTTP_ACCEPT='application/json'
-        )
-        self.assertEqual(response.status_code, 200)
-        self.assertEqual(response['Content-Type'], 'application/json')
+        response = self.client.get(self.test_url)
 
-        json_data = response.json()
-        self.assertEqual(json_data['id'], self.test_id)
-        self.assertEqual(json_data['shortid'], self.test_id[:6].upper())
-        self.assertEqual(json_data['components'], [
-            {
-                'type': 'CPU',
-                'model': 'Intel i7',
-                'manufacturer': 'Intel',
-                'serialNumber': 'SN12345678'
-            },
-            {
-                'type': 'RAM',
-                'size': '8GB',
-                'manufacturer': 'Kingston',
-                'serialNumber': 'SN87654321'
-            }
-        ])
-        self.assertEqual(json_data['serial_number'], 'SN123456')
-        self.assertEqual(json_data['uuids'], [])
-        self.assertEqual(json_data['hids'], ['hid1', 'hid2'])
+        self.assertEqual(response.status_code, 200)
+        self.assertTemplateUsed(response, 'device_web.html')
+
+        self.assertContains(response, 'http://example.com')
+        self.assertContains(response, 'Test Page')

device/views.py

@@ -133,38 +133,15 @@ class PublicDeviceWebView(TemplateView):
         })
         return context
 
-    @property
-    def public_fields(self):
-        return {
+    def get_json_response(self):
+        data = {
             'id': self.object.id,
             'shortid': self.object.shortid,
             'uuids': self.object.uuids,
             'hids': self.object.hids,
-            'components': self.remove_serial_number_from(self.object.components),
+            'components': self.object.components
         }
-
-    @property
-    def authenticated_fields(self):
-        return {
-            'serial_number': self.object.serial_number,
-            'components': self.object.components,
-        }
-
-    def remove_serial_number_from(self, components):
-        for component in components:
-            if 'serial_number' in component:
-                del component['SerialNumber']
-        return components
-
-    def get_device_data(self):
-        data = self.public_fields
-        if self.request.user.is_authenticated:
-            data.update(self.authenticated_fields)
-        return data
-
-    def get_json_response(self):
-        device_data = self.get_device_data()
-        return JsonResponse(device_data)
+        return JsonResponse(data)
 
 
 class AddAnnotationView(DashboardView, CreateView):

evidence/models.py

@@ -19,16 +19,14 @@ class Annotation(models.Model):
     created = models.DateTimeField(auto_now_add=True)
     uuid = models.UUIDField()
     owner = models.ForeignKey(Institution, on_delete=models.CASCADE)
-    user = models.ForeignKey(
-        User, on_delete=models.SET_NULL, null=True, blank=True)
+    user = models.ForeignKey(User, on_delete=models.SET_NULL, null=True, blank=True)
     type =  models.SmallIntegerField(choices=Type)
     key = models.CharField(max_length=STR_EXTEND_SIZE)
     value = models.CharField(max_length=STR_EXTEND_SIZE)
 
     class Meta:
         constraints = [
-            models.UniqueConstraint(
-                fields=["type", "key", "uuid"], name="unique_type_key_uuid")
+            models.UniqueConstraint(fields=["type", "key", "uuid"], name="unique_type_key_uuid")
         ]
 
 
@@ -89,7 +87,7 @@ class Evidence:
         return self.components
 
     def get_manufacturer(self):
-        if self.is_web_snapshot():
+        if self.doc.get("type") == "WebSnapshot":
             kv = self.doc.get('kv', {})
             if len(kv) < 1:
                 return ""
@@ -101,7 +99,7 @@ class Evidence:
         return self.dmi.manufacturer().strip()
 
     def get_model(self):
-        if self.is_web_snapshot():
+        if self.doc.get("type") == "WebSnapshot":
             kv = self.doc.get('kv', {})
             if len(kv) < 2:
                 return ""
@@ -124,11 +122,6 @@ class Evidence:
                 return k
         return ""
 
-    def get_serial_number(self):
-        if self.is_legacy():
-            return self.doc['device']['serialNumber']
-        return self.dmi.serial_number().strip()
-
     @classmethod
     def get_all(cls, user):
         return Annotation.objects.filter(
@@ -143,6 +136,3 @@ class Evidence:
 
     def is_legacy(self):
         return self.doc.get("software") != "workbench-script"
-
-    def is_web_snapshot(self):
-        return self.doc.get("type") == "WebSnapshot"