audit: fix internal server error from passing models
This commit is contained in:
parent
323b4b4a5d
commit
31ea2e7139
|
@ -24,7 +24,7 @@ class PassbookAuthorizationLoadingView(LoginRequiredMixin, LoadingView):
|
||||||
|
|
||||||
def get_url(self):
|
def get_url(self):
|
||||||
querystring = urlencode(self.request.GET)
|
querystring = urlencode(self.request.GET)
|
||||||
return reverse('passbook_providers_oauth:oauth2-ok-authorize')+'?'+querystring
|
return reverse('passbook_providers_oauth:oauth2-ok-authorize') + '?' + querystring
|
||||||
|
|
||||||
|
|
||||||
class OAuthPermissionDenied(PermissionDeniedView):
|
class OAuthPermissionDenied(PermissionDeniedView):
|
||||||
|
@ -78,7 +78,7 @@ class PassbookAuthorizationView(AccessMixin, AuthorizationView):
|
||||||
def form_valid(self, form):
|
def form_valid(self, form):
|
||||||
# User has clicked on "Authorize"
|
# User has clicked on "Authorize"
|
||||||
Event.new(EventAction.AUTHORIZE_APPLICATION,
|
Event.new(EventAction.AUTHORIZE_APPLICATION,
|
||||||
authorized_application=self._application).from_http(self.request)
|
authorized_application=self._application.pk).from_http(self.request)
|
||||||
LOGGER.debug('User authorized Application',
|
LOGGER.debug('User authorized Application',
|
||||||
user=self.request.user, application=self._application)
|
user=self.request.user, application=self._application)
|
||||||
return super().form_valid(form)
|
return super().form_valid(form)
|
||||||
|
|
|
@ -9,6 +9,7 @@ from passbook.policies.engine import PolicyEngine
|
||||||
|
|
||||||
LOGGER = get_logger()
|
LOGGER = get_logger()
|
||||||
|
|
||||||
|
|
||||||
def check_permissions(request, user, client):
|
def check_permissions(request, user, client):
|
||||||
"""Check permissions, used for
|
"""Check permissions, used for
|
||||||
https://django-oidc-provider.readthedocs.io/en/latest/
|
https://django-oidc-provider.readthedocs.io/en/latest/
|
||||||
|
@ -29,6 +30,6 @@ def check_permissions(request, user, client):
|
||||||
return redirect('passbook_providers_oauth:oauth2-permission-denied')
|
return redirect('passbook_providers_oauth:oauth2-permission-denied')
|
||||||
|
|
||||||
Event.new(EventAction.AUTHORIZE_APPLICATION,
|
Event.new(EventAction.AUTHORIZE_APPLICATION,
|
||||||
authorized_application=application,
|
authorized_application=application.pk,
|
||||||
skipped_authorization=False).from_http(request)
|
skipped_authorization=False).from_http(request)
|
||||||
return None
|
return None
|
||||||
|
|
|
@ -124,7 +124,7 @@ class LoginProcessView(AccessRequiredView):
|
||||||
ctx = self.provider.processor.generate_response()
|
ctx = self.provider.processor.generate_response()
|
||||||
# Log Application Authorization
|
# Log Application Authorization
|
||||||
Event.new(EventAction.AUTHORIZE_APPLICATION,
|
Event.new(EventAction.AUTHORIZE_APPLICATION,
|
||||||
authorized_application=self.provider.application,
|
authorized_application=self.provider.application.pk,
|
||||||
skipped_authorization=True).from_http(request)
|
skipped_authorization=True).from_http(request)
|
||||||
return RedirectToSPView.as_view()(
|
return RedirectToSPView.as_view()(
|
||||||
request=request,
|
request=request,
|
||||||
|
@ -144,7 +144,7 @@ class LoginProcessView(AccessRequiredView):
|
||||||
if request.POST.get('ACSUrl', None):
|
if request.POST.get('ACSUrl', None):
|
||||||
# User accepted request
|
# User accepted request
|
||||||
Event.new(EventAction.AUTHORIZE_APPLICATION,
|
Event.new(EventAction.AUTHORIZE_APPLICATION,
|
||||||
authorized_application=self.provider.application,
|
authorized_application=self.provider.application.pk,
|
||||||
skipped_authorization=False).from_http(request)
|
skipped_authorization=False).from_http(request)
|
||||||
return RedirectToSPView.as_view()(
|
return RedirectToSPView.as_view()(
|
||||||
request=request,
|
request=request,
|
||||||
|
|
|
@ -181,7 +181,7 @@ class OAuthCallback(OAuthClientMixin, View):
|
||||||
access.save()
|
access.save()
|
||||||
UserOAuthSourceConnection.objects.filter(pk=access.pk).update(user=user)
|
UserOAuthSourceConnection.objects.filter(pk=access.pk).update(user=user)
|
||||||
Event.new(EventAction.CUSTOM, message="Linked OAuth Source",
|
Event.new(EventAction.CUSTOM, message="Linked OAuth Source",
|
||||||
source=source).from_http(self.request)
|
source=source.pk).from_http(self.request)
|
||||||
if was_authenticated:
|
if was_authenticated:
|
||||||
messages.success(self.request, _("Successfully linked %(source)s!" % {
|
messages.success(self.request, _("Successfully linked %(source)s!" % {
|
||||||
'source': self.source.name
|
'source': self.source.name
|
||||||
|
|
Reference in New Issue