From 3323b5003681365fe1af9760ebd9431af97e8631 Mon Sep 17 00:00:00 2001 From: Jens Langhammer Date: Fri, 27 Aug 2021 10:08:15 +0200 Subject: [PATCH] web/flows: also check for redirects as result of posting challenge Signed-off-by: Jens Langhammer --- web/src/flows/FlowExecutor.ts | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/web/src/flows/FlowExecutor.ts b/web/src/flows/FlowExecutor.ts index f24864b99..fbfc213b9 100644 --- a/web/src/flows/FlowExecutor.ts +++ b/web/src/flows/FlowExecutor.ts @@ -96,6 +96,16 @@ export class FlowExecutor extends LitElement implements StageHost { } private postUpdate(): void { + // Assign the location as soon as we get the challenge and *not* in the render function + // as the render function might be called multiple times, which will navigate multiple + // times and can invalidate oauth codes + if (this.challenge?.type === ChallengeChoices.Redirect) { + console.debug( + "authentik/flows: redirecting to url from server", + (this.challenge as RedirectChallenge).to, + ); + window.location.assign((this.challenge as RedirectChallenge).to); + } tenant().then((tenant) => { if (this.challenge?.flowInfo?.title) { document.title = `${this.challenge.flowInfo?.title} - ${tenant.brandingTitle}`; @@ -120,16 +130,6 @@ export class FlowExecutor extends LitElement implements StageHost { .then((data) => { this.challenge = data; this.postUpdate(); - // Assign the location as soon as we get the challenge and *not* in the render function - // as the render function might be called multiple times, which will navigate multiple - // times and can invalidate oauth codes - if (this.challenge.type === ChallengeChoices.Redirect) { - console.debug( - "authentik/flows: redirecting to url from server", - (this.challenge as RedirectChallenge).to, - ); - window.location.assign((this.challenge as RedirectChallenge).to); - } }) .catch((e: Error | Response) => { this.errorMessage(e);