web: add check compile test to prevent compile errors/warnings

Signed-off-by: Jens Langhammer <jens.langhammer@beryju.org>

.github/workflows/ci-web.yml

@@ -27,6 +27,22 @@ jobs:
       - name: Eslint
         working-directory: web/
         run: npm run lint
+  lint-build:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: actions/setup-node@v3.5.1
+        with:
+          node-version: '16'
+          cache: 'npm'
+          cache-dependency-path: web/package-lock.json
+      - working-directory: web/
+        run: npm ci
+      - name: Generate API
+        run: make gen-client-ts
+      - name: TSC
+        working-directory: web/
+        run: npm run tsc
   lint-prettier:
     runs-on: ubuntu-latest
     steps:

Makefile

@@ -126,7 +126,7 @@ gen: gen-build gen-clean gen-client-ts
 web-build: web-install
 	cd web && npm run build
 
-web: web-lint-fix web-lint
+web: web-lint-fix web-lint web-check-compile
 
 web-install:
 	cd web && npm ci
@@ -144,6 +144,9 @@ web-lint:
 	cd web && npm run lint
 	cd web && npm run lit-analyse
 
+web-check-compile:
+	cd web && npm run tsc
+
 web-extract:
 	cd web && npm run extract
 

web/package.json

@@ -12,6 +12,7 @@
         "lit-analyse": "lit-analyzer src",
         "prettier-check": "prettier --check .",
         "prettier": "prettier --write .",
+        "tsc": "tsc --strict --noEmit",
         "background-image": "npx @squoosh/cli -d src/assets/images --resize '{\"enabled\":true,\"width\":2560,\"method\":\"lanczos3\",\"fitMethod\":\"contain\",\"premultiply\":true,\"linearRGB\":true}' --mozjpeg '{\"quality\":75,\"baseline\":false,\"arithmetic\":false,\"progressive\":true,\"optimize_coding\":true,\"smoothing\":0,\"color_space\":3,\"quant_table\":3,\"trellis_multipass\":false,\"trellis_opt_zero\":false,\"trellis_opt_table\":false,\"trellis_loops\":1,\"auto_subsample\":true,\"chroma_subsample\":2,\"separate_chroma_quality\":false,\"chroma_quality\":75}' src/assets/images/flow_background.jpg"
     },
     "lingui": {

web/src/admin/flows/utils.ts

@@ -18,6 +18,8 @@ export function DesignationToLabel(designation: FlowDesignationEnum): string {
             return t`Stage Configuration`;
         case FlowDesignationEnum.Unenrollment:
             return t`Unenrollment`;
+        case FlowDesignationEnum.UnknownDefaultOpenApi:
+            return t`Unknown designation`;
     }
 }
 
@@ -33,5 +35,7 @@ export function LayoutToLabel(layout: LayoutEnum): string {
             return t`Sidebar left`;
         case LayoutEnum.SidebarRight:
             return t`Sidebar right`;
+        case LayoutEnum.UnknownDefaultOpenApi:
+            return t`Unknown layout`;
     }
 }

web/src/admin/outposts/OutpostForm.ts

@@ -107,6 +107,10 @@ export class OutpostForm extends ModelForm<Outpost, string> {
                             </option>`;
                         });
                     });
+            case OutpostTypeEnum.UnknownDefaultOpenApi:
+                return Promise.resolve([
+                    html` <option value="">${t`Unknown outpost type`}</option>`,
+                ]);
         }
     }
 

web/src/admin/outposts/OutpostListPage.ts

@@ -33,6 +33,8 @@ export function TypeToLabel(type?: OutpostTypeEnum): string {
             return t`Proxy`;
         case OutpostTypeEnum.Ldap:
             return t`LDAP`;
+        case OutpostTypeEnum.UnknownDefaultOpenApi:
+            return t`Unknown type`;
     }
 }
 

web/src/admin/providers/proxy/ProxyProviderForm.ts

@@ -279,6 +279,8 @@ export class ProxyProviderFormPage extends ModelForm<ProxyProvider, number> {
                             ${t`Set this to the domain you wish the authentication to be valid for. Must be a parent domain of the URL above. If you're running applications as app1.domain.tld, app2.domain.tld, set this to 'domain.tld'.`}
                         </p>
                     </ak-form-element-horizontal>`;
+            case ProxyMode.UnknownDefaultOpenApi:
+                return html`<p>${t`Unknown proxy mode`}</p>`;
         }
     }
 

web/src/admin/providers/proxy/ProxyProviderViewPage.ts

@@ -47,6 +47,8 @@ export function ModeToLabel(action?: ProxyMode): string {
             return t`Forward auth (single application)`;
         case ProxyMode.ForwardDomain:
             return t`Forward auth (domain-level)`;
+        case ProxyMode.UnknownDefaultOpenApi:
+            return t`Unknown proxy mode`;
     }
 }
 
@@ -57,6 +59,8 @@ export function isForward(mode: ProxyMode): boolean {
         case ProxyMode.ForwardSingle:
         case ProxyMode.ForwardDomain:
             return true;
+        case ProxyMode.UnknownDefaultOpenApi:
+            return false;
     }
 }
 

web/src/admin/sources/oauth/OAuthSourceViewPage.ts

@@ -27,8 +27,9 @@ import PFBase from "@patternfly/patternfly/patternfly-base.css";
 import { OAuthSource, ProviderTypeEnum, SourcesApi } from "@goauthentik/api";
 
 export function ProviderToLabel(provider?: ProviderTypeEnum): string {
-    if (!provider) return "";
     switch (provider) {
+        case undefined:
+            return "";
         case ProviderTypeEnum.Apple:
             return "Apple";
         case ProviderTypeEnum.Azuread:
@@ -51,6 +52,10 @@ export function ProviderToLabel(provider?: ProviderTypeEnum): string {
             return "Reddit";
         case ProviderTypeEnum.Twitter:
             return "Twitter";
+        case ProviderTypeEnum.Twitch:
+            return "Twitch";
+        case ProviderTypeEnum.UnknownDefaultOpenApi:
+            return t`Unknown provider type`;
     }
 }
 

web/src/admin/sources/oauth/utils.ts

@@ -15,5 +15,7 @@ export function UserMatchingModeToLabel(mode?: UserMatchingModeEnum): string {
             return t`Link to a user with identical username. Can have security implications when a username is used with another source`;
         case UserMatchingModeEnum.UsernameDeny:
             return t`Use the user's username, but deny enrollment when the username already exists`;
+        case UserMatchingModeEnum.UnknownDefaultOpenApi:
+            return t`Unknown user matching mode`;
     }
 }

web/src/admin/tokens/TokenListPage.ts

@@ -27,6 +27,8 @@ export function IntentToLabel(intent: IntentEnum): string {
             return t`Recovery`;
         case IntentEnum.Verification:
             return t`Verification`;
+        case IntentEnum.UnknownDefaultOpenApi:
+            return t`Unknown intent`;
     }
 }
 

web/src/elements/Diagram.ts

@@ -35,7 +35,10 @@ export class Diagram extends AKElement {
         const matcher = window.matchMedia("(prefers-color-scheme: light)");
         const handler = (ev?: MediaQueryListEvent) => {
             mermaid.initialize({
-                logLevel: "fatal",
+                // The type definition for this says number
+                // but the example use strings
+                // and numbers don't work
+                logLevel: "fatal" as unknown as number,
                 startOnLoad: false,
                 theme: ev?.matches || matcher.matches ? "default" : "dark",
                 flowchart: {

web/src/elements/table/Table.ts

@@ -202,7 +202,7 @@ export abstract class Table<T> extends AKElement {
                 let comp = (item: T) => {
                     return JSON.stringify(item) === jsonRes;
                 };
-                if ("pk" in res) {
+                if (Object.hasOwn(res as object, "pk")) {
                     comp = (item: T) => {
                         return (
                             (item as unknown as { pk: string | number }).pk ===