From d01fd7cdb721591a4fae36a190910d385bf7bd67 Mon Sep 17 00:00:00 2001
From: Jens Langhammer <jens.langhammer@beryju.org>
Date: Fri, 16 Apr 2021 17:06:06 +0200
Subject: [PATCH] web/admin: fix error when user doesn't have permissions to
 read source

Signed-off-by: Jens Langhammer <jens.langhammer@beryju.org>
---
 .../pages/user-settings/UserSettingsPage.ts   |  2 +-
 .../settings/SourceSettingsOAuth.ts           | 31 +++++++++----------
 2 files changed, 16 insertions(+), 17 deletions(-)

diff --git a/web/src/pages/user-settings/UserSettingsPage.ts b/web/src/pages/user-settings/UserSettingsPage.ts
index d475167d2..8f474ff03 100644
--- a/web/src/pages/user-settings/UserSettingsPage.ts
+++ b/web/src/pages/user-settings/UserSettingsPage.ts
@@ -56,7 +56,7 @@ export class UserSettingsPage extends LitElement {
     renderSourceSettings(source: UserSetting): TemplateResult {
         switch (source.component) {
             case "ak-user-settings-source-oauth":
-                return html`<ak-user-settings-source-oauth objectId=${source.objectUid}>
+                return html`<ak-user-settings-source-oauth objectId=${source.objectUid} title=${source.title}>
                 </ak-user-settings-source-oauth>`;
             default:
                 return html`<p>${t`Error: unsupported source settings: ${source.component}`}</p>`;
diff --git a/web/src/pages/user-settings/settings/SourceSettingsOAuth.ts b/web/src/pages/user-settings/settings/SourceSettingsOAuth.ts
index cd41a465b..a3d1eeeff 100644
--- a/web/src/pages/user-settings/settings/SourceSettingsOAuth.ts
+++ b/web/src/pages/user-settings/settings/SourceSettingsOAuth.ts
@@ -1,6 +1,6 @@
-import { customElement, html, TemplateResult } from "lit-element";
+import { customElement, html, property, TemplateResult } from "lit-element";
 import { BaseUserSettings } from "./BaseUserSettings";
-import { OAuthSource, SourcesApi } from "authentik-api";
+import { SourcesApi } from "authentik-api";
 import { until } from "lit-html/directives/until";
 import { DEFAULT_CONFIG } from "../../../api/Config";
 import { t } from "@lingui/macro";
@@ -9,22 +9,21 @@ import { AppURLManager } from "../../../api/legacy";
 @customElement("ak-user-settings-source-oauth")
 export class SourceSettingsOAuth extends BaseUserSettings {
 
+    @property()
+    title!: string;
+
     render(): TemplateResult {
-        return html`${until(new SourcesApi(DEFAULT_CONFIG).sourcesOauthRead({
-            slug: this.objectId
-        }).then((source) => {
-            return html`<div class="pf-c-card">
-                <div class="pf-c-card__title">
-                    ${t`Source ${source.name}`}
-                </div>
-                <div class="pf-c-card__body">
-                    ${this.renderInner(source)}
-                </div>
-            </div>`;
-        }))}`;
+        return html`<div class="pf-c-card">
+            <div class="pf-c-card__title">
+                ${t`Source ${this.title}`}
+            </div>
+            <div class="pf-c-card__body">
+                ${this.renderInner()}
+            </div>
+        </div>`;
     }
 
-    renderInner(source: OAuthSource): TemplateResult {
+    renderInner(): TemplateResult {
         return html`${until(new SourcesApi(DEFAULT_CONFIG).sourcesOauthUserConnectionsList({
             sourceSlug: this.objectId
         }).then((connection) => {
@@ -41,7 +40,7 @@ export class SourceSettingsOAuth extends BaseUserSettings {
             }
             return html`<p>${t`Not connected.`}</p>
                 <a class="pf-c-button pf-m-primary"
-                    href=${AppURLManager.sourceOAuth(source.slug, "login")}>
+                    href=${AppURLManager.sourceOAuth(this.objectId, "login")}>
                     ${t`Connect`}
                 </a>`;
         }))}`;