From e3ac774a189b9a1deb86bf4049b5a54e1cde6994 Mon Sep 17 00:00:00 2001 From: Ken Sternberg <133134217+kensternberg-authentik@users.noreply.github.com> Date: Mon, 23 Oct 2023 10:48:16 -0700 Subject: [PATCH] web: 3 fixes for small typos, annoyances, and improvements (#7249) I'm conducting a more comprehensive survey of the UI in order to get a more holistic idea of the changes that should be implemented. Along the way, I'm finding a few small details that annoy me. Here are three. It goes to "User statistics." I have changed both the text of the link and the page to read "User Statistics" (it's a title, it should be capitalized). Give people warning when you're about to take them out of the system, especially if you're opening a new tab along the way. Just a thing I spotted along the way. --- web/src/admin/AdminInterface.ts | 2 +- .../admin/admin-overview/AdminOverviewPage.ts | 21 +++++++++++++++---- .../admin/admin-overview/DashboardUserPage.ts | 2 +- website/docs/flow/stages/prompt/index.md | 2 +- 4 files changed, 20 insertions(+), 7 deletions(-) diff --git a/web/src/admin/AdminInterface.ts b/web/src/admin/AdminInterface.ts index 44d927ae2..984b74916 100644 --- a/web/src/admin/AdminInterface.ts +++ b/web/src/admin/AdminInterface.ts @@ -193,7 +193,7 @@ export class AdminInterface extends Interface { ["/if/user/", msg("User interface"), { "?isAbsoluteLink": true, "?highlight": true }], [null, msg("Dashboards"), { "?expanded": true }, [ ["/administration/overview", msg("Overview")], - ["/administration/dashboard/users", msg("Users")], + ["/administration/dashboard/users", msg("User Statistics")], ["/administration/system-tasks", msg("System Tasks")]]], [null, msg("Applications"), null, [ ["/core/providers", msg("Providers"), [`^/core/providers/(?${ID_REGEX})$`]], diff --git a/web/src/admin/admin-overview/AdminOverviewPage.ts b/web/src/admin/admin-overview/AdminOverviewPage.ts index a892cbdf3..a7e210a7c 100644 --- a/web/src/admin/admin-overview/AdminOverviewPage.ts +++ b/web/src/admin/admin-overview/AdminOverviewPage.ts @@ -22,6 +22,7 @@ import PFContent from "@patternfly/patternfly/components/Content/content.css"; import PFList from "@patternfly/patternfly/components/List/list.css"; import PFPage from "@patternfly/patternfly/components/Page/page.css"; import PFGrid from "@patternfly/patternfly/layouts/Grid/grid.css"; +import PFBase from "@patternfly/patternfly/patternfly-base.css"; import { SessionUser } from "@goauthentik/api"; @@ -35,6 +36,7 @@ export function versionFamily(): string { export class AdminOverviewPage extends AKElement { static get styles(): CSSResult[] { return [ + PFBase, PFGrid, PFPage, PFContent, @@ -53,6 +55,13 @@ export class AdminOverviewPage extends AKElement { .card-container { max-height: 10em; } + .ak-external-link { + display: inline-block; + margin-left: 0.175rem; + vertical-align: super; + line-height: normal; + font-size: var(--pf-global--icon--FontSize--sm); + } `, ]; } @@ -104,8 +113,10 @@ export class AdminOverviewPage extends AKElement { class="pf-u-mb-xl" target="_blank" href="https://goauthentik.io/integrations/" - >${msg("Explore integrations")} + >${msg("Explore integrations")}
  • ${msg("Check release notes")} + >${msg("Check the release notes")}
    • diff --git a/web/src/admin/admin-overview/DashboardUserPage.ts b/web/src/admin/admin-overview/DashboardUserPage.ts index 721873767..94e788bf4 100644 --- a/web/src/admin/admin-overview/DashboardUserPage.ts +++ b/web/src/admin/admin-overview/DashboardUserPage.ts @@ -41,7 +41,7 @@ export class DashboardUserPage extends AKElement { } render(): TemplateResult { - return html` + return html`
    diff --git a/website/docs/flow/stages/prompt/index.md b/website/docs/flow/stages/prompt/index.md index 0efff1056..2bb33418b 100644 --- a/website/docs/flow/stages/prompt/index.md +++ b/website/docs/flow/stages/prompt/index.md @@ -20,7 +20,7 @@ The prompt can be any of the following types: | Number | Numerical textbox. | | Checkbox | Simple checkbox. | | Radio Button Group | Similar to checkboxes, but allows selecting a value from a set of predefined values. | -| Dropdwon | A simple dropdown menu filled with predefined values. | +| Dropdown | A simple dropdown menu filled with predefined values. | | Date | Same as text, except the client renders a date-picker | | Date-time | Same as text, except the client renders a date-time-picker | | File | Allow users to upload a file, which will be available as base64-encoded data in the flow . |